shahrs87 commented on a change in pull request #3283:
URL: https://github.com/apache/hbase/pull/3283#discussion_r635483682
##########
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/replication/regionserver/ReplicationSourceWALReader.java
##########
@@ -165,6 +165,12 @@ public void run() {
} catch (InterruptedException e) {
LOG.trace("Interrupted while sleeping between WAL reads");
Thread.currentThread().interrupt();
+ } catch (WALEntryFilterRetryableException e) {
Review comment:
I see this exception is supposed to originate from [`filterEntry` method
](https://github.com/apache/hbase/blob/master/hbase-server/src/main/java/org/apache/hadoop/hbase/replication/regionserver/ReplicationSourceWALReader.java#L355)
and `filter#filter` method doesn't throw any checked exception. Thats why we
need to extend RuntimeException.
Can we add a `catch(WALEntryFilterRetryableException)` in `filterEntry`
method and convert that into an IOException so that [`catch (IOException)
here`](https://github.com/apache/hbase/blob/master/hbase-server/src/main/java/org/apache/hadoop/hbase/replication/regionserver/ReplicationSourceWALReader.java#L158-L163)
will handle the retry.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
