shahrs87 commented on a change in pull request #3283:
URL: https://github.com/apache/hbase/pull/3283#discussion_r635506795



##########
File path: 
hbase-server/src/main/java/org/apache/hadoop/hbase/replication/regionserver/ReplicationSourceWALReader.java
##########
@@ -165,6 +165,12 @@ public void run() {
         } catch (InterruptedException e) {
           LOG.trace("Interrupted while sleeping between WAL reads");
           Thread.currentThread().interrupt();
+        } catch (WALEntryFilterRetryableException e) {

Review comment:
       Makes sense.  Can we club the handling of IOException and 
WALEntryFilterRetryableException 
    exceptions 
[here](https://github.com/apache/hbase/blob/master/hbase-server/src/main/java/org/apache/hadoop/hbase/replication/regionserver/ReplicationSourceWALReader.java#L155-L163)
 something like `catch (IOException | WALEntryFilterRetryableException e)` 
since we want to take the same path as non eof exception takes.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to