Apache9 commented on a change in pull request #3293:
URL: https://github.com/apache/hbase/pull/3293#discussion_r638542942
##########
File path:
hbase-client/src/main/java/org/apache/hadoop/hbase/zookeeper/ReadOnlyZKClient.java
##########
@@ -344,6 +344,10 @@ private void run() {
} catch (IOException e) {
task.connectFailed(e);
continue;
+ } catch (Exception e) {
+ // won't be doing any retries for non IOE.
+ task.closed(e);
Review comment:
FWIW, if you think this is an unrecoverable error, we should just quit
the whole ReadOnlyZKClient loop, instead of calling closed here but do not
break out the loop? If not, why give up retry at the first time?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
