anoopsjohn commented on a change in pull request #3293:
URL: https://github.com/apache/hbase/pull/3293#discussion_r640456137
##########
File path:
hbase-client/src/main/java/org/apache/hadoop/hbase/zookeeper/ReadOnlyZKClient.java
##########
@@ -344,6 +344,10 @@ private void run() {
} catch (IOException e) {
task.connectFailed(e);
continue;
+ } catch (Exception e) {
+ // won't be doing any retries for non IOE.
+ task.closed(e);
Review comment:
I got ur view Duo. Thanks. Ya I took a middle approach. Thought about
this also.
I am very much fine for handling Exception as how we do IOE and do
connectFailed(). After retry anyways will come out. Ideally the exception will
be IOE. I read like u also okf with that. I will make that change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
