mnpoonia commented on a change in pull request #3372:
URL: https://github.com/apache/hbase/pull/3372#discussion_r658492987
##########
File path:
hbase-client/src/main/java/org/apache/hadoop/hbase/client/TableDescriptor.java
##########
@@ -275,11 +275,11 @@
/**
* Check if normalization enable flag of the table is true. If flag is false
- * then no region normalizer won't attempt to normalize this table.
+ * then region normalizer won't attempt to normalize this table.
*
- * @return true if region normalization is enabled for this table
+ * @return value of NORMALIZATION_ENABLED key for this table if present else
return defaultValue
*/
- boolean isNormalizationEnabled();
+ boolean isNormalizationEnabled(boolean defaulValue);
Review comment:
That make sense.
I was trying to define a logical definition about what will override the
other. So currently we have a default value for table descriptor. What i am
trying to do is remove it from the default list and define default at
hbase-site level. So going forward - either this property will be present or
not. and if not present then hbase-site value will be used and if present then
the value defined by table descriptor will be used.
Let me fix this pattern in code and make it clear.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
