virajjasani commented on a change in pull request #3372:
URL: https://github.com/apache/hbase/pull/3372#discussion_r661975280
##########
File path:
hbase-client/src/main/java/org/apache/hadoop/hbase/client/TableDescriptor.java
##########
@@ -275,11 +275,11 @@
/**
* Check if normalization enable flag of the table is true. If flag is false
- * then no region normalizer won't attempt to normalize this table.
+ * then region normalizer won't attempt to normalize this table.
*
- * @return true if region normalization is enabled for this table
+ * @return value of NORMALIZATION_ENABLED key for this table if present else
return null
*/
- boolean isNormalizationEnabled();
+ Boolean isNormalizationEnabled();
Review comment:
I think null handling could cause compatibility issue and hence might
not make this eligible to land on branch-2 and branch-1 minor releases.
@Apache9 @ndimiduk Wondering if it is good idea to deprecate this one and add
new API that returns an enum with values: {TRUE, FALSE, NOT_PRESENT_IN_TD} to
clearly migrate from here to new one?
This is to maintain source compatibility and with new API, we can make
decision of whether to use site config or TD property value and then it can go
to minor releases on branch-2.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
