z-york commented on a change in pull request #90:
URL:
https://github.com/apache/hbase-operator-tools/pull/90#discussion_r661803931
##########
File path: hbase-hbck2/pom.xml
##########
@@ -235,6 +235,12 @@
<version>2.1.0</version>
<scope>test</scope>
</dependency>
+ <dependency>
+ <groupId>com.github.stephenc.findbugs</groupId>
+ <artifactId>findbugs-annotations</artifactId>
+ <version>${findbugs-annotations.version}</version>
Review comment:
I'm not very familiar with the findbugs annotations. I guess we could
change to using Preconditions or something, but that will be a runtime check.
If findbugs is doing something at compile time with those annotations, it might
not be a comparable switch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
