busbey commented on a change in pull request #90:
URL:
https://github.com/apache/hbase-operator-tools/pull/90#discussion_r661812267
##########
File path: hbase-hbck2/pom.xml
##########
@@ -235,6 +235,12 @@
<version>2.1.0</version>
<scope>test</scope>
</dependency>
+ <dependency>
+ <groupId>com.github.stephenc.findbugs</groupId>
+ <artifactId>findbugs-annotations</artifactId>
+ <version>${findbugs-annotations.version}</version>
Review comment:
Looks like it's all `CheckForNull` annotations to make spotbugs /
findbugs do a better job of warning about usage.
https://spotbugs.readthedocs.io/en/stable/annotations.html#edu-umd-cs-findbugs-annotations-checkfornull
Any particular reason you want to get this out of here @saintstack ? we have
the stephenc clean room findbugs dependency in lots of places across the
project already.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
