Apache9 commented on pull request #3458: URL: https://github.com/apache/hbase/pull/3458#issuecomment-873610356
> The cluster key must no be null. I have met a problem in master-slave cluster replication, user misconfigured the cluster key like CLUSTER_KEY => "zk1.com:2181:/hbase " . the znode parent was end with a blank. We did not validate it when add peer, but it will cause enable_table_replication failed. You could see the code in ReplicationPeerManager https://github.com/apache/hbase/blob/1883889e26fd1bac73630f48d1c6e9adab0230e4/hbase-server/src/main/java/org/apache/hadoop/hbase/master/replication/ReplicationPeerManager.java#L361 Only if the endpoint is HBaseInterClusterReplicationEndpoint we will check the peer config. Buy anyway, I think it is fine to check null here as if you need the clusterKey to be null, just do not call this method. Please add some javadoc for the methdo to mention that you should not call it with null value, if you want to it to be null, just do not call this method. Thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
