pankaj72981 commented on pull request #3458:
URL: https://github.com/apache/hbase/pull/3458#issuecomment-873988222
> > IMO we should not allow empty cluster key when endpoint is
HBaseInterClusterReplicationEndpoint.
> > WDYT @Apache9
>
> We have this check logic in ReplicationPeerManager.
Just went throug the AddPeerProcedure..
AddPeerProcedure#prePeerModification
ReplicationPeerManager#preAddPeer
ReplicationPeerManager#checkPeerConfig
ReplicationPeerManager#checkClusterKey
ZKConfig#validateClusterKey
ZKConfig#transformClusterKey
In the transformClusterKey(), we access key without any validation, so here
we may faceNPE.
Pardon me @Apache9 , did I miss anything?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
