Apache9 commented on a change in pull request #3464:
URL: https://github.com/apache/hbase/pull/3464#discussion_r667481666
##########
File path:
hbase-server/src/test/java/org/apache/hadoop/hbase/MiniHBaseCluster.java
##########
@@ -436,6 +436,27 @@ public void waitForMasterToStop(ServerName serverName,
long timeout) throws IOEx
return startRegionServer(newConf);
}
+ /**
+ * Starts a compaction server thread running
+ *
+ * @throws IOException
Review comment:
nit: remove empty throws doc
##########
File path:
hbase-server/src/test/java/org/apache/hadoop/hbase/MiniHBaseCluster.java
##########
@@ -557,6 +592,15 @@ public String waitOnRegionServer(final int serverNumber) {
return this.hbaseCluster.waitOnRegionServer(serverNumber);
}
+ /**
+ * Wait for the specified compaction server to stop. Removes this thread
from list
+ * of running threads.
+ * @param serverNumber
Review comment:
nits: remove empty param doc
##########
File path:
hbase-server/src/test/java/org/apache/hadoop/hbase/compactionserver/TestCompactionServer.java
##########
@@ -277,20 +289,20 @@ public void testCompactionOffloadTableDescriptor() throws
Exception {
TableDescriptor htd =
TableDescriptorBuilder.newBuilder(TEST_UTIL.getAdmin().getDescriptor(TABLENAME))
- .setCompactionOffloadEnabled(true).build();
+ .setCompactionOffloadEnabled(false).build();
TEST_UTIL.getAdmin().modifyTable(htd);
TEST_UTIL.waitUntilAllRegionsAssigned(TABLENAME);
// invoke compact
TEST_UTIL.compact(TABLENAME, false);
- TEST_UTIL.waitFor(6000, () -> COMPACTION_SERVER.requestCount.sum() > 0);
- long requestCount = COMPACTION_SERVER.requestCount.sum();
+ Thread.sleep(1000);
Review comment:
Mind explaining a bit here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
