YutSean commented on a change in pull request #3474:
URL: https://github.com/apache/hbase/pull/3474#discussion_r669257177
##########
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/CombinedBlockCache.java
##########
@@ -79,7 +79,7 @@ public Cacheable getBlock(BlockCacheKey cacheKey, boolean
caching,
boolean repeat, boolean updateCacheMetrics) {
// TODO: is there a hole here, or just awkwardness since in the lruCache
getBlock
// we end up calling l2Cache.getBlock.
- return lruCache.containsBlock(cacheKey)?
+ return cacheKey.getBlockType().getCategory() == BlockCategory.DATA?
Review comment:
As in branch-1 it is also possible that data blocks are cached in L1, so
that it is not a good way to check L1 or L2 according to the block type. I have
update the logic in the last commit.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
