YutSean commented on a change in pull request #3474:
URL: https://github.com/apache/hbase/pull/3474#discussion_r670057960
##########
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/CombinedBlockCache.java
##########
@@ -79,7 +79,13 @@ public Cacheable getBlock(BlockCacheKey cacheKey, boolean
caching,
boolean repeat, boolean updateCacheMetrics) {
// TODO: is there a hole here, or just awkwardness since in the lruCache
getBlock
// we end up calling l2Cache.getBlock.
- return lruCache.containsBlock(cacheKey)?
+ boolean existInL1 = lruCache.containsBlock(cacheKey);
+ if (!existInL1 && updateCacheMetrics) {
+ // If the block does not exist in L1, this check should be counted as a
miss.
+ combinedCacheStats.lruCacheStats
+ .miss(caching, cacheKey.isPrimary(), cacheKey.getBlockType());
+ }
+ return existInL1?
Review comment:
The former line is without space, should I add one here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
