rda3mon commented on a change in pull request #3359:
URL: https://github.com/apache/hbase/pull/3359#discussion_r677931600
##########
File path:
hbase-backup/src/main/java/org/apache/hadoop/hbase/backup/impl/BackupManifest.java
##########
@@ -512,11 +512,11 @@ public void addDependentImage(BackupImage image) {
* Set the incremental timestamp map directly.
* @param incrTimestampMap timestamp map
*/
- public void setIncrTimestampMap(HashMap<TableName, HashMap<String, Long>>
incrTimestampMap) {
+ public void setIncrTimestampMap(Map<TableName, Map<String, Long>>
incrTimestampMap) {
this.backupImage.setIncrTimeRanges(incrTimestampMap);
}
- public Map<TableName, HashMap<String, Long>> getIncrTimestampMap() {
+ public Map<TableName, Map<String, Long>> getIncrTimestampMap() {
Review comment:
Sure. Will keep this on mind.
For this particular thing, it was related. For BackupLogCleaner
`getIncrTimestampMap` was to be stored as part of BackupInfo and restored.
Proto deser was resulting into Type mismatch between Map and HashMap. So, I had
to club this as part of same PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
