joshelser commented on a change in pull request #3536:
URL: https://github.com/apache/hbase/pull/3536#discussion_r679486302
##########
File path: hbase-client/src/main/java/org/apache/hadoop/hbase/client/Admin.java
##########
@@ -1253,6 +1253,15 @@ default boolean balancer() throws IOException {
*/
boolean balance() throws IOException;
+ /**
+ * Invoke the balancer in dry run mode. Will show plan but not actually move
any regions.
+ * Can NOT run for various reasons. Check logs.
+ *
+ * @return <code>true</code> if dry run ran, <code>false</code> otherwise.
+ * @throws IOException if a remote or network exception occurs
+ */
+ boolean dryRunBalance() throws IOException;
Review comment:
> I'm not sure how the hbase devs weigh interface change questions like
this.
Yeah, that's exactly the problem ;). As you have added it now, you've added
a new method to the public API which we would not be able to remove before
HBase 4.0.0 at this point. Meaning, we want to be very cautious when adding new
methods on public API.
I believe our specification technically allow us to define a single method
on the interface to be at a lesser visibility (not Public), but it's not
something we typically do, especially on one of the most user-facing interfaces.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
