bbeaudreault commented on a change in pull request #3536:
URL: https://github.com/apache/hbase/pull/3536#discussion_r679875879
##########
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/master/LoadBalancer.java
##########
@@ -86,6 +86,18 @@
// We deliberately use 'localhost' so the operation will fail fast
ServerName BOGUS_SERVER_NAME = ServerName.valueOf("localhost,1,1");
+ enum RunMode {
+ CHORE, REQUEST, FORCE, DRY_RUN;
+
+ boolean isForced() {
+ return this == FORCE;
+ }
+
+ boolean isDryRun() {
+ return this == DRY_RUN;
+ }
Review comment:
I find a function wrapper to be easier to read (and less verbose) when
enum values are repeatedly compared like we are doing. This is probably
personal preference though, so I've removed them.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
