bbeaudreault commented on pull request #3536: URL: https://github.com/apache/hbase/pull/3536#issuecomment-893838032
I just pushed a commit which makes the changes we talked about in the Admin and RSGroupAdmin interfaces. I still need to update the shell, will do that tomorrow. Overall I like how this came out, as I said I used a factory for now because we really don't have enough arguments to justify a builder. One thing I don't love is the duplication between hmaster and rsgroup, but that seems to be the name of the game with rsgroup for now. It caused a little bit of funkiness in order to handle the more strict RSGroupAdminServer interface though (i.e. the private BalanceRequest.forRunMode method). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
