saintstack commented on a change in pull request #3553:
URL: https://github.com/apache/hbase/pull/3553#discussion_r685683628
##########
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/RegionScannerImpl.java
##########
@@ -768,7 +768,7 @@ public synchronized boolean reseek(byte[] row) throws
IOException {
}
@Override
- public void shipped() throws IOException {
+ public synchronized void shipped() throws IOException {
Review comment:
Looking at RegionScannerImpl, we synchronize on reseek, close, next,
isFilterDone. shipped checks for storeHeap and joinedHeap being null before it
goes to use them... Close will null them when it closes. Seems to make sense
synchronizing on shipped. What you think @Apache9
Any perf concerns or anything seen in production @sunhelly ? Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
