wchevreuil commented on a change in pull request #3617:
URL: https://github.com/apache/hbase/pull/3617#discussion_r695258019



##########
File path: 
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionFileSystem.java
##########
@@ -648,11 +651,35 @@ public Path commitDaughterRegion(final RegionInfo 
regionInfo)
       if (!rename(daughterTmpDir, regionDir)) {
         throw new IOException("Unable to rename " + daughterTmpDir + " to " + 
regionDir);
       }
+      loadRegionFilesIntoStoreTracker(regionDir);
     }
-
     return regionDir;
   }
 
+  private void loadRegionFilesIntoStoreTracker(Path regionDir) throws 
IOException {

Review comment:
       I tried to get the list of splits/merged files form the split/merge 
procedure, but it doesn't work if we don't have this on top of the changes from 
HBASE-26187. This is because without HBASE-26187, these lists of files would 
still be under .split or .merges temp dirs. However, we are doing a renaming in 
the commit method before trying to load into the tracker, so then when trying 
to create storefileinfo to add to tracker, the path we have for splits/merges 
is not valid anymore.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to