wchevreuil commented on a change in pull request #3617:
URL: https://github.com/apache/hbase/pull/3617#discussion_r695540715
##########
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionFileSystem.java
##########
@@ -648,11 +651,35 @@ public Path commitDaughterRegion(final RegionInfo
regionInfo)
if (!rename(daughterTmpDir, regionDir)) {
throw new IOException("Unable to rename " + daughterTmpDir + " to " +
regionDir);
}
+ loadRegionFilesIntoStoreTracker(regionDir);
}
-
return regionDir;
}
+ private void loadRegionFilesIntoStoreTracker(Path regionDir) throws
IOException {
Review comment:
Even with all that refactoring, I would still have the same problem:
When link files are created for split/merge regions, these are created under
temp dir (currently, without HBASE-26187). So even with a list of all those
references in memory, we cannot simply add this list to the StoreFileTracker,
because these links in the list are under a temp directory. We would need to
iterate through this list and update the links paths to point to the actual
directory (after the region dir has been renamed), at commit time, before we
can add the list to tracker.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
