Apache9 commented on a change in pull request #3610:
URL: https://github.com/apache/hbase/pull/3610#discussion_r695543775
##########
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/rsgroup/RSGroupInfoManagerImpl.java
##########
@@ -1205,6 +1222,8 @@ private void moveTablesAndWait(Set<TableName> tables,
String targetGroup) throws
ProcedureSyncWait.waitForProcedureToCompleteIOE(masterServices.getMasterProcedureExecutor(),
proc, Long.MAX_VALUE);
}
+ LOG.info("Move tables done. Moved {} tables to {}: {}", tables.size(),
targetGroup,
+
tables.stream().map(TableName::getNameAsString).collect(Collectors.toSet()));
Review comment:
I think tableName.toString is the same with getNameAsString? So we do
not need to generate a new String set?
##########
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/rsgroup/RSGroupInfoManagerImpl.java
##########
@@ -1270,7 +1289,9 @@ public void moveServers(Set<Address> servers, String
targetGroupName) throws IOE
Set<Address> movedServers = moveServers(servers, srcGrp.getName(),
targetGroupName);
moveServerRegionsFromGroup(movedServers, srcGrp.getServers(),
targetGroupName, srcGrp.getName());
- LOG.info("Move servers done: {} => {}", srcGrp.getName(),
targetGroupName);
+ LOG.info("Move servers done. Moved {} servers {} => {}: {}",
movedServers.size(),
+ srcGrp.getName(), targetGroupName,
+
movedServers.stream().map(Address::toString).collect(Collectors.toSet()));
Review comment:
Also here, I do not think we need to call toString explicitly...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
