Apache9 commented on a change in pull request #3610:
URL: https://github.com/apache/hbase/pull/3610#discussion_r696715950
##########
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/rsgroup/RSGroupInfoManagerImpl.java
##########
@@ -1205,6 +1221,7 @@ private void moveTablesAndWait(Set<TableName> tables,
String targetGroup) throws
ProcedureSyncWait.waitForProcedureToCompleteIOE(masterServices.getMasterProcedureExecutor(),
proc, Long.MAX_VALUE);
}
+ LOG.info("Move tables done. Moved {} tables to {}: {}", tables.size(),
targetGroup, tables);
Review comment:
We will log too much if the level is info here? Can we just info the
size and the target group, and add another debug log to log all the tables?
##########
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/rsgroup/RSGroupInfoManagerImpl.java
##########
@@ -1270,7 +1287,8 @@ public void moveServers(Set<Address> servers, String
targetGroupName) throws IOE
Set<Address> movedServers = moveServers(servers, srcGrp.getName(),
targetGroupName);
moveServerRegionsFromGroup(movedServers, srcGrp.getServers(),
targetGroupName, srcGrp.getName());
- LOG.info("Move servers done: {} => {}", srcGrp.getName(),
targetGroupName);
+ LOG.info("Move servers done. Moved {} servers from {} => {}: {}",
movedServers.size(),
Review comment:
Ditto, I'm afraid it will too much to also log all the servers name, but
log the size in info and then all the servers with debug.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
