bbeaudreault commented on a change in pull request #3630:
URL: https://github.com/apache/hbase/pull/3630#discussion_r697605000
##########
File path: hbase-client/src/main/java/org/apache/hadoop/hbase/client/Admin.java
##########
@@ -2494,10 +2516,20 @@ boolean snapshotCleanupSwitch(final boolean on, final
boolean synchronous)
/**
* Balance regions in the given RegionServer group
* @param groupName the group name
- * @return boolean Whether balance ran or not
+ * @return BalanceResponse details about the balancer run
* @throws IOException if a remote or network exception occurs
*/
- boolean balanceRSGroup(String groupName) throws IOException;
+ default BalanceResponse balanceRSGroup(String groupName) throws IOException {
Review comment:
The only release branch I plan to merge this into is branch-2 (for
release 2.5.0), via https://github.com/apache/hbase/pull/3536. I do make a
[similar
change](https://github.com/apache/hbase/pull/3536/files#diff-2c719668f99214384467187a522407097ce8f0cc3b9df4c577ae67b0e445378dR72)
there, but the interface there is annotated as IA.PRIVATE. So it seems like
that's ok?
Since it's now in Admin, we'd have to be more careful. But I don't think
version 3 has been released yet, so again seems ok?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
