bbeaudreault commented on a change in pull request #3630:
URL: https://github.com/apache/hbase/pull/3630#discussion_r697605703
##########
File path: hbase-protocol-shaded/src/main/protobuf/server/master/Master.proto
##########
@@ -293,11 +293,14 @@ message IsInMaintenanceModeResponse {
}
message BalanceRequest {
- optional bool force = 1;
+ optional bool ignore_rit = 1;
Review comment:
No, this was discussed in https://github.com/apache/hbase/pull/3536 but
the TL;DR is that protobuf does not care about the field name, just the ordinal
on the right. It might break compilation for anyone who directly depends on
protobuf. But as part of the DISCUSS Thread on the dev list, it was decided
that protobufs are IA Private or LimitedPrivate and as such this chagne was ok
from that perspective. But just to reiterate, this is wire compatible due to
how protobuf handles (de)serialization
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
