bbeaudreault commented on a change in pull request #3660:
URL: https://github.com/apache/hbase/pull/3660#discussion_r701993188
##########
File path:
hbase-balancer/src/main/java/org/apache/hadoop/hbase/master/balancer/StochasticLoadBalancer.java
##########
@@ -206,13 +219,13 @@ protected float getDefaultSlop() {
@Override
protected void loadConf(Configuration conf) {
super.loadConf(conf);
- maxSteps = conf.getInt(MAX_STEPS_KEY, maxSteps);
- stepsPerRegion = conf.getInt(STEPS_PER_REGION_KEY, stepsPerRegion);
- maxRunningTime = conf.getLong(MAX_RUNNING_TIME_KEY, maxRunningTime);
- runMaxSteps = conf.getBoolean(RUN_MAX_STEPS_KEY, runMaxSteps);
+ maxSteps = conf.getInt(MAX_STEPS_KEY, DEFAULT_MAX_STEPS);
Review comment:
I audited all other usages of conf.getXXX in the balancer and didn't see
any other instances of this
##########
File path:
hbase-balancer/src/main/java/org/apache/hadoop/hbase/master/balancer/StochasticLoadBalancer.java
##########
@@ -206,13 +219,13 @@ protected float getDefaultSlop() {
@Override
protected void loadConf(Configuration conf) {
super.loadConf(conf);
- maxSteps = conf.getInt(MAX_STEPS_KEY, maxSteps);
- stepsPerRegion = conf.getInt(STEPS_PER_REGION_KEY, stepsPerRegion);
- maxRunningTime = conf.getLong(MAX_RUNNING_TIME_KEY, maxRunningTime);
- runMaxSteps = conf.getBoolean(RUN_MAX_STEPS_KEY, runMaxSteps);
+ maxSteps = conf.getInt(MAX_STEPS_KEY, DEFAULT_MAX_STEPS);
Review comment:
I audited all other usages of conf.getXXX in the balancer and didn't see
any other instances of this pattern.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
