bbeaudreault commented on a change in pull request #3660:
URL: https://github.com/apache/hbase/pull/3660#discussion_r701995880
##########
File path:
hbase-balancer/src/main/java/org/apache/hadoop/hbase/master/balancer/StochasticLoadBalancer.java
##########
@@ -240,10 +253,9 @@ protected void loadConf(Configuration conf) {
curFunctionCosts = new double[costFunctions.size()];
tempFunctionCosts = new double[costFunctions.size()];
- LOG.info("Loaded config; maxSteps=" + maxSteps + ", runMaxSteps=" +
runMaxSteps,
- ", stepsPerRegion=" + stepsPerRegion +
- ", maxRunningTime=" + maxRunningTime + ", isByTable=" + isByTable + ",
CostFunctions=" +
- Arrays.toString(getCostFunctionNames()) + " etc.");
+ LOG.info("Loaded config; maxSteps={}, runMaxSteps={}, stepsPerRegion={},
maxRunningTime={}, "
Review comment:
Since this is slf4j, this would only print out `Loaded config;
maxSteps=1000000, runMaxSteps=false` and drop the rest. This is because these
extra args are considered format arguments, but there are no variables in the
format string. I updated this to the proper slf4j usage so the rest of the
intended details could be printed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
