wchevreuil commented on pull request #3666: URL: https://github.com/apache/hbase/pull/3666#issuecomment-916141073
> Yes, I was thinking we should store the StoreEngine config as a whole. For example, if we use StripeCompaction in the past but later we change the default config to DateTieredCompaction, should we switch all the tables' config? At least for me, I do not think so. I agree with this approach. Adds flexibility. And if we then realise there's appeal to allow for changing all tables at once, maybe we can add tooling for this? > But anyway, changing stripe to date tiered will not cause data loss, only impact performance, so could be a separated issue, and let;s discuss more. I'm not too familiar with the internals of each of these impls, so can't opine much now. > Let's change the title to narrow down the scope to store file tracker only. Done. > And I think we'd beter add a method in StoreFileTracker, like > > `void persistConfiguration(TableDescriptorBuilder builder);` > > To store all the necessary configurations to the TableDescriptor. For example, for MigrationStoreFileTracker, we need to store the src and dst store file tracker implementation as well. Makes sense and gives extensibility. I realised StoreFileTracker is tightened to stores, so we may also choose to persist tracker config on CF descriptor. For now, am putting into table, though, as it gives the chance for operators to override it at CF level. Let me know if you feel we should persist at CF descriptor, @Apache9 . -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
