Apache9 commented on a change in pull request #3666:
URL: https://github.com/apache/hbase/pull/3666#discussion_r705461121
##########
File path:
hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestAdmin.java
##########
@@ -423,6 +425,10 @@ private void testCloneTableSchema(final TableName
tableName, final TableName new
assertEquals(BLOCK_SIZE,
newTableDesc.getColumnFamily(FAMILY_1).getBlocksize());
assertEquals(BLOCK_CACHE,
newTableDesc.getColumnFamily(FAMILY_1).isBlockCacheEnabled());
assertEquals(TTL, newTableDesc.getColumnFamily(FAMILY_1).getTimeToLive());
+ //HBASE-26246 introduced persist of store file tracker into table
descriptor
Review comment:
nit: space after '//'
##########
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/storefiletracker/StoreFileTrackerFactory.java
##########
@@ -40,10 +41,13 @@
public static final String TRACK_IMPL = "hbase.store.file-tracker.impl";
private static final Logger LOG =
LoggerFactory.getLogger(StoreFileTrackerFactory.class);
+ public static Class<? extends StoreFileTracker>
getStoreFileTrackerImpl(Configuration conf){
Review comment:
nit: space before '{'
##########
File path:
hbase-server/src/test/java/org/apache/hadoop/hbase/master/procedure/MasterProcedureTestingUtility.java
##########
@@ -226,6 +228,11 @@ public static void validateTableCreation(final HMaster
master, final TableName t
assertTrue("family not found " + family[i],
htd.getColumnFamily(Bytes.toBytes(family[i])) != null);
}
assertEquals(family.length, htd.getColumnFamilyCount());
+
+ //checks store file tracker impl has been properly set in htd
Review comment:
nit: space after '//'
##########
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/storefiletracker/StoreFileTrackerBase.java
##########
@@ -78,6 +82,15 @@ public final void replace(Collection<StoreFileInfo>
compactedFiles,
}
}
+ @Override
+ public void persistConfiguration(TableDescriptorBuilder builder) {
+ if(StringUtils.isEmpty(builder.getValue(TRACK_IMPL))){
Review comment:
nit: space after 'if' and before '{'
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
