Apache9 commented on a change in pull request #3666:
URL: https://github.com/apache/hbase/pull/3666#discussion_r706622256
##########
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/storefiletracker/StoreFileTrackerFactory.java
##########
@@ -54,7 +55,7 @@ public static StoreFileTracker create(Configuration conf,
boolean isPrimaryRepli
ColumnFamilyDescriptorBuilder.newBuilder(Bytes.toBytes(family));
StoreContext ctx =
StoreContext.getBuilder().withColumnFamilyDescriptor(fDescBuilder.build())
.withRegionFileSystem(regionFs).build();
- return StoreFileTrackerFactory.create(conf, TRACK_IMPL, isPrimaryReplica,
ctx);
+ return StoreFileTrackerFactory.create(conf, isPrimaryReplica, ctx);
Review comment:
Good. This is the root cause of the failing UTs.
##########
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/storefiletracker/StoreFileTrackerFactory.java
##########
@@ -6,9 +6,7 @@
* to you under the Apache License, Version 2.0 (the
* "License"); you may not use this file except in compliance
* with the License. You may obtain a copy of the License at
- *
- * http://www.apache.org/licenses/LICENSE-2.0
- *
+ * http://www.apache.org/licenses/LICENSE-2.0
Review comment:
This is unnecessary?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
