wchevreuil commented on a change in pull request #3721:
URL: https://github.com/apache/hbase/pull/3721#discussion_r724919715
##########
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/storefiletracker/StoreFileTrackerFactory.java
##########
@@ -100,13 +102,19 @@ static String getStoreFileTrackerName(Class<? extends
StoreFileTracker> clazz) {
}
}
- public static StoreFileTracker create(Configuration conf, boolean
isPrimaryReplica,
+ private static StoreFileTracker getInstance(Configuration conf, boolean
isPrimaryReplica,
StoreContext ctx) {
Class<? extends StoreFileTracker> tracker = getTrackerClass(conf);
LOG.info("instantiating StoreFileTracker impl {}", tracker.getName());
return ReflectionUtils.newInstance(tracker, conf, isPrimaryReplica, ctx);
}
+ public static StoreFileTracker create(Configuration conf, boolean
isPrimaryReplica,
Review comment:
Yes, this was relevant for the original solution only, when we had an
init() method. let me revert this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
