wchevreuil commented on a change in pull request #3721:
URL: https://github.com/apache/hbase/pull/3721#discussion_r724952316
##########
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/storefiletracker/StoreFileTrackerFactory.java
##########
@@ -158,12 +166,12 @@ static StoreFileTrackerBase
createForMigration(Configuration conf, String config
return ReflectionUtils.newInstance(tracker, conf, isPrimaryReplica, ctx);
}
- public static void persistTrackerConfig(Configuration conf,
TableDescriptorBuilder builder) {
+ public static void updateDescriptor(Configuration conf,
TableDescriptorBuilder builder) {
TableDescriptor tableDescriptor = builder.build();
ColumnFamilyDescriptor cfDesc = tableDescriptor.getColumnFamilies()[0];
StoreContext context =
StoreContext.getBuilder().withColumnFamilyDescriptor(cfDesc).build();
- StoreFileTracker tracker = StoreFileTrackerFactory.create(conf, true,
context);
- tracker.persistConfiguration(builder);
+ StoreFileTracker tracker = StoreFileTrackerFactory.getInstance(conf, true,
context);
Review comment:
> Here we should create a new Composite configration to merge the global
conf and TableDescriptor?
I think we don't really need this extra merge here, as once we have it into
table descriptors, it's what will be used when opening the store. Besides, it
would add extra complexity to set the newly created compound configuration into
the MasterProcedureEnvironmet instance we have at CreateTableProcedure.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
