[
https://issues.apache.org/jira/browse/HBASE-26345?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17427289#comment-17427289
]
Andrew Kyle Purtell commented on HBASE-26345:
---------------------------------------------
[~vjasani]
This is well written.
The doc is missing a minor point about ring buffers in that it is ok and
expected to begin overwriting entries after a wrap-around, this is how they
re-use the oldest entries for storing the newest, but it can be inferred.
If I didn't know anything about this feature and I was reading the doc, I would
wonder if the slow log persistence stuff can be reused for another NQ and how I
might go about doing that. I can see that it is more than just configuration,
some coding is required, would be useful to explain/diagram this, but not
required.
I didn't double check the API details with the code but did read them to check
that it all makes sense.
+1 from me, looks great
> Design doc for HBase NamedQueue framework
> -----------------------------------------
>
> Key: HBASE-26345
> URL: https://issues.apache.org/jira/browse/HBASE-26345
> Project: HBase
> Issue Type: Task
> Reporter: Viraj Jasani
> Assignee: Viraj Jasani
> Priority: Major
> Attachments: Online NamedQueue framework with optional persistence
> layer.pdf
>
>
> We have a couple of usecases already being served by the NamedQueue
> framework. It would be good to also provide a design doc to provide the high
> level system components view and let other usecases be onboarded with ease.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
