BukrosSzabolcs commented on a change in pull request #3786:
URL: https://github.com/apache/hbase/pull/3786#discussion_r735736298
##########
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/compactions/Compactor.java
##########
@@ -537,4 +547,17 @@ protected InternalScanner createScanner(HStore store,
ScanInfo scanInfo,
return new StoreScanner(store, scanInfo, scanners, smallestReadPoint,
earliestPutTs,
dropDeletesFromRow, dropDeletesToRow);
}
+
+ public List<Path> getCompactionTargets(){
+ if (writer == null){
Review comment:
You are right, there is a slight gap between setting the writer to null
and replacing the storefile list. Thanks for pointing it out.
I would prefer to put the writer reset call to `HStore` in `doCompaction`,
just after the `replaceStoreFiles` call. It would have the downside that
StoreEngine has to expose the reset method, but I would argue moving it any
lower on the call chain would just involve additional complications ( being
called during `replayCompactionMarker`, handling different StoreEngine
implementations )
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
