wchevreuil commented on a change in pull request #3786:
URL: https://github.com/apache/hbase/pull/3786#discussion_r736329025
##########
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/compactions/Compactor.java
##########
@@ -537,4 +547,17 @@ protected InternalScanner createScanner(HStore store,
ScanInfo scanInfo,
return new StoreScanner(store, scanInfo, scanners, smallestReadPoint,
earliestPutTs,
dropDeletesFromRow, dropDeletesToRow);
}
+
+ public List<Path> getCompactionTargets(){
+ if (writer == null){
Review comment:
> I would prefer to put the writer reset call to HStore in doCompaction,
just after the replaceStoreFiles call.
So move `commitWriter` call out of `Compactor.compact`? Or do you plan to
move the nulling of write to a `resetWriter` method?
> It would have the downside that StoreEngine has to expose the reset
method, but I would argue moving it any lower on the call chain would just
involve additional complications ( being called during replayCompactionMarker,
handling different StoreEngine implementations )
Yeah, looks like your suggestion is less complex, and you have an idea of
the impacts, so I just trust your judgement.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
