ddupg opened a new pull request #3806:
URL: https://github.com/apache/hbase/pull/3806


   Failed to add a peer replicating to non-HBase(like MQ) by implementing 
custom ReplicationEndpoint,  got exception like this in my UT: 
   ```
   2021-10-29T15:14:47,632 INFO  [RPCClient-NioEventLoopGroup-5-3] 
client.RawAsyncHBaseAdmin$ReplicationProcedureBiConsumer(2761): Operation: 
ADD_REPLICATION_PEER, peerId: 1 failed with Invalid cluster key: , should not 
replicate to itself for 
HBaseInterClusterReplicationEndpoint2021-10-29T15:14:47,632 INFO  
[RPCClient-NioEventLoopGroup-5-3] 
client.RawAsyncHBaseAdmin$ReplicationProcedureBiConsumer(2761): Operation: 
ADD_REPLICATION_PEER, peerId: 1 failed with Invalid cluster key: , should not 
replicate to itself for HBaseInterClusterReplicationEndpoint
   org.apache.hadoop.hbase.DoNotRetryIOException: Invalid cluster key: , should 
not replicate to itself for HBaseInterClusterReplicationEndpoint
    at java.lang.Thread.getStackTrace(Thread.java:1559)
    at 
org.apache.hadoop.hbase.util.FutureUtils.setStackTrace(FutureUtils.java:130)
    at org.apache.hadoop.hbase.util.FutureUtils.rethrow(FutureUtils.java:149)
    at org.apache.hadoop.hbase.util.FutureUtils.get(FutureUtils.java:186)
    at org.apache.hadoop.hbase.client.Admin.addReplicationPeer(Admin.java:1948)
    at org.apache.hadoop.hbase.client.Admin.addReplicationPeer(Admin.java:1936)
    at 
org.apache.hadoop.hbase.replication.TestNonHBaseReplicationEndpoint.test(TestNonHBaseReplicationEndpoint.java:97)
    at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
    at 
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
    at 
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
    at java.lang.reflect.Method.invoke(Method.java:498)
    at 
org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:59)
    at 
org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
    at 
org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:56)
    at 
org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17)
    at 
org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:26)
    at org.junit.runners.ParentRunner$3.evaluate(ParentRunner.java:306)
    at 
org.junit.runners.BlockJUnit4ClassRunner$1.evaluate(BlockJUnit4ClassRunner.java:100)
    at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:366)
    at 
org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:103)
    at 
org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:63)
    at org.junit.runners.ParentRunner$4.run(ParentRunner.java:331)
    at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:79)
    at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:329)
    at org.junit.runners.ParentRunner.access$100(ParentRunner.java:66)
    at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:293)
    at 
org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:26)
    at 
org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:27)
    at org.apache.hadoop.hbase.SystemExitRule$1.evaluate(SystemExitRule.java:38)
    at 
org.junit.internal.runners.statements.FailOnTimeout$CallableStatement.call(FailOnTimeout.java:288)
    at 
org.junit.internal.runners.statements.FailOnTimeout$CallableStatement.call(FailOnTimeout.java:282)
    at java.util.concurrent.FutureTask.run(FutureTask.java:266)
    at java.lang.Thread.run(Thread.java:748)
    at --------Future.get--------(Unknown Source)
    at 
org.apache.hadoop.hbase.master.replication.ReplicationPeerManager.checkClusterId(ReplicationPeerManager.java:527)
    at 
org.apache.hadoop.hbase.master.replication.ReplicationPeerManager.checkPeerConfig(ReplicationPeerManager.java:367)
    at 
org.apache.hadoop.hbase.master.replication.ReplicationPeerManager.preAddPeer(ReplicationPeerManager.java:123)
    at 
org.apache.hadoop.hbase.master.replication.AddPeerProcedure.prePeerModification(AddPeerProcedure.java:101)
    at 
org.apache.hadoop.hbase.master.replication.ModifyPeerProcedure.executeFromState(ModifyPeerProcedure.java:162)
    at 
org.apache.hadoop.hbase.master.replication.ModifyPeerProcedure.executeFromState(ModifyPeerProcedure.java:43)
    at 
org.apache.hadoop.hbase.procedure2.StateMachineProcedure.execute(StateMachineProcedure.java:190)
    at 
org.apache.hadoop.hbase.procedure2.Procedure.doExecute(Procedure.java:953)
    at 
org.apache.hadoop.hbase.procedure2.ProcedureExecutor.execProcedure(ProcedureExecutor.java:1667)
    at 
org.apache.hadoop.hbase.procedure2.ProcedureExecutor.executeProcedure(ProcedureExecutor.java:1414)
    at 
org.apache.hadoop.hbase.procedure2.ProcedureExecutor.access$1100(ProcedureExecutor.java:78)
    at 
org.apache.hadoop.hbase.procedure2.ProcedureExecutor$WorkerThread.run(ProcedureExecutor.java:1981)
   ```
   HBASE-24743 ignored this situation and introduced this bug.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to