shahrs87 commented on a change in pull request #3806:
URL: https://github.com/apache/hbase/pull/3806#discussion_r739180443
##########
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/master/replication/ReplicationPeerManager.java
##########
@@ -358,13 +358,13 @@ private void checkPeerConfig(ReplicationPeerConfig
peerConfig) throws DoNotRetry
e);
}
}
- // Default is HBaseInterClusterReplicationEndpoint and only it need to
check cluster key
- if (endpoint == null || endpoint instanceof
HBaseInterClusterReplicationEndpoint) {
+ // Endpoints implementing HBaseReplicationEndpoint need to check cluster
key
+ if (endpoint == null || endpoint instanceof HBaseReplicationEndpoint) {
Review comment:
As for this issue, it doesn't matter whether it is an instance of
`HBaseInterClusterReplicationEndpoint` or `HBaseReplicationEndpoint`, correct ?
since the test is skipping the check completely.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
