ndimiduk commented on a change in pull request #3762:
URL: https://github.com/apache/hbase/pull/3762#discussion_r742258747
##########
File path: conf/hbase-env.sh
##########
@@ -143,10 +143,32 @@
# export GREP="${GREP-grep}"
# export SED="${SED-sed}"
-# Uncomment to enable trace, you can change the options to use other exporters
such as jaeger or
-# zipkin. See
https://github.com/open-telemetry/opentelemetry-java-instrumentation on how to
+# Tracing
+# Uncomment some combination of these lines to enable tracing. You should
change the options to use
+# the exporters appropriate to your environment. See
+# https://github.com/open-telemetry/opentelemetry-java-instrumentation for
details on how to
# configure exporters and other components through system properties.
-# export HBASE_TRACE_OPTS="-Dotel.resource.attributes=service.name=HBase
-Dotel.traces.exporter=logging -Dotel.metrics.exporter=none"
+#
+# The presence HBASE_TRACE_OPTS indicates that tracing should be enabled, and
serves as site-wide
+# settings.
+# export HBASE_TRACE_OPTS="-Dotel.traces.exporter=none
-Dotel.metrics.exporter=none"
+#
+# Per-process configuration variables allow for fine-grained configuration
control.
+# export HBASE_SHELL_OPTS="${HBASE_SHELL_OPTS} ${HBASE_TRACE_OPTS}
-Dotel.resource.attributes=service.name=hbase-shell"
Review comment:
@joshelser
So, uncomment all the process-specific configurations by default,
effectively populating those environment variables all the time, even when
tracing is not enabled? Or you mean that we would detect the presence of
`HBASE_TRACE_OPTS` in code, and then populate the other values with hard-coded
settings?
I can imaging an environment where there are two HBase clusters, and the use
application is dynamically dispatching requests to the different environments
(HA clusters type of deployment). In that case, the operator has likely
configured the `service.name` for a region server in cluster A differently than
for a region serve cluster B. I think it's better to not make assumptions for
the operator -- this approach gives them complete control, while also providing
a reasonable default that available by simply uncommenting a few extra lines.
I agree that this is super verbose and am open to alternative suggestions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
