ndimiduk commented on a change in pull request #3762:
URL: https://github.com/apache/hbase/pull/3762#discussion_r742260321
##########
File path: bin/hbase
##########
@@ -493,7 +493,9 @@ add_jdk11_deps_to_classpath() {
}
add_opentelemetry_agent() {
- if ! agent_jar=$(find lib/trace -type f -name "opentelemetry-javaagent-*"
2>/dev/null); then
+ if [ -e "${OPENTELEMETRY_JAVAAGENT_PATH}" ] ; then
+ agent_jar="${OPENTELEMETRY_JAVAAGENT_PATH}"
+ elif ! agent_jar=$(find "${HBASE_HOME}/lib/trace" -type f -name
"opentelemetry-javaagent-*" 2>/dev/null); then
Review comment:
Umm, maybe? It's true that we care about the thing the link resolves to.
let me try it with `-L`, see if there's a difference. FYI, the above code is
working fine for me...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
