BukrosSzabolcs commented on a change in pull request #3786:
URL: https://github.com/apache/hbase/pull/3786#discussion_r744817192



##########
File path: 
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/compactions/AbstractMultiOutputCompactor.java
##########
@@ -79,5 +79,6 @@ protected void abortWriter(T writer) throws IOException {
           e);
       }
     }
+    writer = null;

Review comment:
       The reset method was introduced to allow resetting the writer from 
outside of a compactor, when the new files gets committed as storefiles. We 
also have reset it in every abortWriter, but since these methods have direct 
access to the variable I would prefer to do it like this instead of calling the 
reset method.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to