Apache9 commented on a change in pull request #3786:
URL: https://github.com/apache/hbase/pull/3786#discussion_r744858544
##########
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/compactions/AbstractMultiOutputCompactor.java
##########
@@ -79,5 +79,6 @@ protected void abortWriter(T writer) throws IOException {
e);
}
}
+ writer = null;
Review comment:
It is just a bit weird that we set writer to null directly in these
methods while we do not in some other methods. Please add some comments to
explain the reason, that we will only call reset from upper layer when we
successfully commit the writers so if we fail to commit the writers, we need to
reset it by our own.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
