Apache9 commented on pull request #3862: URL: https://github.com/apache/hbase/pull/3862#issuecomment-974674843
> > The comment of the method says it will only call System.exit when a nonzero return code is returned from the run method? > > @Apache9 good catch. Changed the comment. Please review again. What I mean is that the method is design to be like the old behavior, so we need to make sure that it is OK for us to change the behavior. We could fix a bug introduced by the old behavior but we may introduce more bugs if we change the behavior... Of course I'm not telling that we can not apply the patch, but we need to take more care. Thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
