Apache9 commented on pull request #3862: URL: https://github.com/apache/hbase/pull/3862#issuecomment-974808700
The code is pretty old... https://github.com/apache/hbase/commit/02cd4a9b019a8b86b4d077e8bec8c69d7579fae5 This is the commit, a refactoring actually, and there is a comment `// Otherwise exit gracefully so other threads clean up` So I think we do not call System.exit when ret is zero is intentional. A zero return value means a normal shutdown, so here we want all the threads clean themselves up and then exit gracefully. The problem here is that, why a crashed region server could return zero here? Why it does not return a non zero value? Sorry for sticking on the behavior here, the modification is pretty simple but it is very foundamental... Thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
