busbey opened a new pull request #3901: URL: https://github.com/apache/hbase/pull/3901
copying the problem summary from HBASE-26469 > The `clean_exit.rb` invocations ought to exit with success, exit code 0. > > | | 1.4.14 | 1.7.1 | 2.0.6 | 2.1.9 | 2.2.7 | 2.3.7 | 2.4.8 | master | > | --- |-------|-----|------|-------|------|------|------|--------| > | cli, default | 0 | 0 | 0 | 0 | 0 | 0 | 1 | 1* | > | cli, -n | 0 | 0 | 0 | 0 | 0 | 0 | 1 | hang | > | stdin, default | 0 | 0 | 0 | 0 | 0 | 0 | 0 | 0 | > | stdin, -n | 1 | 1 | 1 | 1 | 1 | 1 | 1* | 1* | > > The `error_exit.rb` invocation should return a non-zero exit code, unless we're specifically trying to match a normal hbase shell session. > > | | 1.4.14 | 1.7.1 | 2.0.6 | 2.1.9 | 2.2.7 | 2.3.7 | 2.4.8 | master | > |-----|----|-----|-----|------|----| ----| ---- | ----| > | cli, default | 1 | 1 | 1 | 1 | 1 | 1 | 1* | 1* | > | cli, -n | 1 | 1 | 1 | 1 | 1 | 1 | 1* | hang | > | stdin, default | 0 | 0 | 0 | 0 | 0 | 0 | 0 | 0 | > | stdin, -n | 1 | 1 | 1 | 1 | 1 | 1 | 1* | 1* | > > In cases marked with * the error details are different. this WIP PR on branch-2.4 has the following summary: clean_exit: | | PR | |--|---| | cli, default | 0 | | cli, -n | 0 | | stdin, default | 0 | | stdin, -n | 0 | error_exit: | | PR | |--|---| | cli, default | 0 | | cli, -n | 1 | | stdin, default | 0 | | stdin, -n | 0 | none of the error_exit give unrelated error messages, e.g ``` (base) sbusbey@Seans-MacBook-Pro hbase-2.4.9-SNAPSHOT % ./bin/hbase shell -n ../tmp/error_exit.rb 2021-11-30 13:30:21,656 WARN [main] util.NativeCodeLoader: Unable to load native-hadoop library for your platform... using builtin-java classes where applicable hbase:001:0> list TABLE 0 row(s) Took 0.3448 seconds => [] hbase:002:0> exit 1 (base) sbusbey@Seans-MacBook-Pro hbase-2.4.9-SNAPSHOT % echo $? 1 ``` full log attached: [hbase-2.4.9-SNAP-with-fix-exit-behavior.log](https://github.com/apache/hbase/files/7629381/hbase-2.4.9-SNAP-with-fix-exit-behavior.log) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
