ndimiduk commented on a change in pull request #3901:
URL: https://github.com/apache/hbase/pull/3901#discussion_r765185385
##########
File path: hbase-shell/src/main/ruby/shell.rb
##########
@@ -302,33 +315,13 @@ def get_workspace
# Install all the hbase commands, constants, and instance variables
@shell and @hbase. This
# will override names that conflict with IRB methods like "help".
export_all(hbase_receiver)
+ # make it so calling exit will hit our pass-through rather than going
directly to IRB
+ hbase_receiver.send :define_singleton_method, :exit, lambda { |rc = 0|
Review comment:
Why must this be done via runtime injection instead of defining a method
on the `HBaseReceiver` class?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
