sunhelly commented on a change in pull request #3893:
URL: https://github.com/apache/hbase/pull/3893#discussion_r768284017
##########
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/CacheConfig.java
##########
@@ -40,8 +40,12 @@
public static final CacheConfig DISABLED = new CacheConfig();
/**
- * Configuration key to cache data blocks on read. Bloom blocks and index
blocks are always be
- * cached if the block cache is enabled.
+ * Configuration key to turn on block cache. There are separate switches for
read and write.
+ */
+ public static final String BLOCKCACHE_ENABLED = "hbase.block.enabled";
+
Review comment:
Did you meat some issues that make you separate these configs to resolve
them? I don't think an additional "hbase.block.enabled" is needed, this will
make users confused with which meaning of 'block' here. For the meta blocks the
cache should not be disabled, and this is the original design.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
