YutSean commented on a change in pull request #3893:
URL: https://github.com/apache/hbase/pull/3893#discussion_r768290278



##########
File path: 
hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/CacheConfig.java
##########
@@ -40,8 +40,12 @@
   public static final CacheConfig DISABLED = new CacheConfig();
 
   /**
-   * Configuration key to cache data blocks on read. Bloom blocks and index 
blocks are always be
-   * cached if the block cache is enabled.
+   * Configuration key to turn on block cache. There are separate switches for 
read and write.
+   */
+  public static final String BLOCKCACHE_ENABLED = "hbase.block.enabled";
+

Review comment:
       Right, these changes seems a little bit superfluous. In this case, may I 
just close this MR and the corresponding jira ticket?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to