comnetwork commented on a change in pull request #3947:
URL: https://github.com/apache/hbase/pull/3947#discussion_r776562958
##########
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/ChunkCreator.java
##########
@@ -134,51 +134,36 @@ public static ChunkCreator getInstance() {
return instance;
}
- /**
- * Creates and inits a chunk. The default implementation for a specific
chunk size.
- * @return the chunk that was initialized
- */
- Chunk getChunk(ChunkType chunkType) {
- return getChunk(CompactingMemStore.IndexType.ARRAY_MAP, chunkType);
Review comment:
@Apache9 , thank you very much for review, what performance issue do you
mean?
For this PR, we do not change the index type of segment from `ARRAY_MAP`
to `CHUNK_MAP`, the index type of segment remains same, which is determined by
`CompactingMemStore` ctor, for the segments which index type are
`ARRAY_MAP`，they do not use `ChunkCreator` and `MemStoreLAB` to allocate cell,
so there is no influence on them.
This PR just change the type of Chunk which should be `CHUNK_MAP` from the
incorrect `ARRAY_MAP` type to the correct `CHUNK_MAP` type, so in my opinion,
there is no performance difference because the code path of get a chunk from
`ChunkCreator` is almost the same.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
