comnetwork commented on a change in pull request #3947:
URL: https://github.com/apache/hbase/pull/3947#discussion_r776622247
##########
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/ChunkCreator.java
##########
@@ -134,51 +134,36 @@ public static ChunkCreator getInstance() {
return instance;
}
- /**
- * Creates and inits a chunk. The default implementation for a specific
chunk size.
- * @return the chunk that was initialized
- */
- Chunk getChunk(ChunkType chunkType) {
- return getChunk(CompactingMemStore.IndexType.ARRAY_MAP, chunkType);
Review comment:
@Apache9 , thank you for feedback, the `IndexChunk` itself makes no
difference no matter it for `ARRAY_MAP` or `CHUNK_MAP`，it is just a chunk of
byte array, and in fact, for `ARRAY_MAP`, there is no `IndexChunk` at all .
Here although `CellChunkImmutableSegment.allocIndexChunks` allocates
`IndexChunk` for `ARRAY_MAP`，but it still use it as `CHUNK_MAP` to write the
chunk id and the cell start offset and size to it to reference the data cells.
So there is no performance difference about reading the cell from
`CellChunkImmutableSegment`. I think it may be just a clerical error here to
use `ARRAY_MAP` for index chunks，because for `ARRAY_MAP`, there is no
`IndexChunk` at all .
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
