frostruan commented on a change in pull request #3920:
URL: https://github.com/apache/hbase/pull/3920#discussion_r777224704
##########
File path:
hbase-client/src/main/java/org/apache/hadoop/hbase/client/RawAsyncHBaseAdmin.java
##########
@@ -1871,48 +1871,55 @@ public void onComplete() {
return failedFuture(e);
}
CompletableFuture<Void> future = new CompletableFuture<>();
- final SnapshotRequest request =
SnapshotRequest.newBuilder().setSnapshot(snapshot).build();
- addListener(this.<Long> newMasterCaller()
- .action((controller, stub) -> this.<SnapshotRequest, SnapshotResponse,
Long> call(controller,
- stub, request, (s, c, req, done) -> s.snapshot(c, req, done),
- resp -> resp.getExpectedTimeout()))
- .call(), (expectedTimeout, err) -> {
+ final SnapshotRequest request =
+
SnapshotRequest.newBuilder().setSnapshot(snapshot).setNonceGroup(ng.getNonceGroup())
+ .setNonce(ng.newNonce()).build();
+ addListener(this.<SnapshotResponse> newMasterCaller()
+ .action((controller, stub) ->
+ this.<SnapshotRequest, SnapshotResponse, SnapshotResponse>
call(controller, stub,
+ request, (s, c, req, done) -> s.snapshot(c, req, done), resp ->
resp))
+ .call(), (resp, err) -> {
if (err != null) {
future.completeExceptionally(err);
return;
}
- TimerTask pollingTask = new TimerTask() {
- int tries = 0;
- long startTime = EnvironmentEdgeManager.currentTime();
- long endTime = startTime + expectedTimeout;
- long maxPauseTime = expectedTimeout / maxAttempts;
-
- @Override
- public void run(Timeout timeout) throws Exception {
- if (EnvironmentEdgeManager.currentTime() < endTime) {
- addListener(isSnapshotFinished(snapshotDesc), (done, err2) -> {
- if (err2 != null) {
- future.completeExceptionally(err2);
- } else if (done) {
- future.complete(null);
- } else {
- // retry again after pauseTime.
- long pauseTime =
-
ConnectionUtils.getPauseTime(TimeUnit.NANOSECONDS.toMillis(pauseNs), ++tries);
- pauseTime = Math.min(pauseTime, maxPauseTime);
- AsyncConnectionImpl.RETRY_TIMER.newTimeout(this, pauseTime,
- TimeUnit.MILLISECONDS);
- }
- });
- } else {
- future.completeExceptionally(
- new SnapshotCreationException("Snapshot '" +
snapshot.getName() +
- "' wasn't completed in expectedTime:" + expectedTimeout + "
ms", snapshotDesc));
+ if (resp.hasProcId()) {
Review comment:
Ok, I'll address it ASAP.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
