ndimiduk edited a comment on pull request #3969:
URL: https://github.com/apache/hbase/pull/3969#issuecomment-1006012719
> Are there any shell scripts which might have called the old `dump()`
static method you removed?
Oh, nice thinking. Yeah, looks like `admin.rb`.
```
$ find . -type f ! -iname '*.java' -exec grep -iIn 'ZKUtil' {} \+
./bin/draining_servers.rb:29:java_import
org.apache.hadoop.hbase.zookeeper.ZKUtil
./bin/draining_servers.rb:96: ZKUtil.createAndFailSilent(zkw, node)
./bin/draining_servers.rb:113: ZKUtil.deleteNodeFailSilent(zkw, node)
./bin/draining_servers.rb:129: servers = ZKUtil.listChildrenNoWatch(zkw,
parentZnode)
./CHANGES.txt:1126: HBASE-3633 ZKUtil::createSetData should only create a
node when it
./hbase-server/target/classes/hbase-webapps/master/zk.jsp:22:
import="org.apache.hadoop.hbase.zookeeper.ZKUtil"
./hbase-server/target/classes/hbase-webapps/master/zk.jsp:41:
<pre><%= StringEscapeUtils.escapeHtml4(ZKUtil.dump(watcher).trim()) %></pre>
./hbase-archetypes/hbase-client-project/target/classes/log4j2.xml:90:
<Logger name="org.apache.hadoop.hbase.zookeeper.ZKUtil" level="debug"/>
./hbase-archetypes/hbase-client-project/target/build-archetype/src/main/resources/log4j2.xml:90:
<Logger name="org.apache.hadoop.hbase.zookeeper.ZKUtil" level="debug"/>
./hbase-archetypes/hbase-client-project/src/main/resources/log4j2.xml:90:
<Logger name="org.apache.hadoop.hbase.zookeeper.ZKUtil" level="debug"/>
./hbase-archetypes/hbase-shaded-client-project/target/classes/log4j2.xml:90:
<Logger name="org.apache.hadoop.hbase.zookeeper.ZKUtil" level="debug"/>
./hbase-archetypes/hbase-shaded-client-project/target/build-archetype/src/main/resources/log4j2.xml:90:
<Logger name="org.apache.hadoop.hbase.zookeeper.ZKUtil" level="debug"/>
./hbase-archetypes/hbase-shaded-client-project/src/main/resources/log4j2.xml:90:
<Logger name="org.apache.hadoop.hbase.zookeeper.ZKUtil" level="debug"/>
./.git/COMMIT_EDITMSG:3:This refactor reduces the size and scope of the
`ZKUtil` class. The core of this refactor is
./.git/COMMIT_EDITMSG:4:moving the `login*` methods from `ZKUtil` into their
own class, `ZKAuthentication`. The class
./.git/COMMIT_EDITMSG:26:# modified:
hbase-zookeeper/src/main/java/org/apache/hadoop/hbase/zookeeper/ZKUtil.java
./.git/COMMIT_EDITMSG:28:# modified:
hbase-zookeeper/src/test/java/org/apache/hadoop/hbase/zookeeper/TestZKUtilNoServer.java
./conf/log4j2.xml:90: <Logger
name="org.apache.hadoop.hbase.zookeeper.ZKUtil" level="debug"/>
./hbase-shell/target/classes/hbase/admin.rb:480:
org.apache.hadoop.hbase.zookeeper.ZKUtil.dump(@zk_wrapper)
./hbase-shell/src/main/ruby/hbase/admin.rb:480:
org.apache.hadoop.hbase.zookeeper.ZKUtil.dump(@zk_wrapper)
```
> Is it possible to deprecate the old method and have it just call the new
location of the utility in the `ZKDump` class instead?
I could, but why? You want to protect users who are calling into an
IA.Private class?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
